trjhtr

I wrote a glypicon as a link to delete a comment:

<a class="delCommentLink" href="% url 'article:comment_delete' comment.id %">
 <span id=" comment.id " class="glyphicon glyphicon-trash" aria-hidden="true">delete</span>
</a>

I send the request using Ajax.

1. retrieve the comment_url
   


2. get the grand-grand-parent element to hide


3. send request to views.py and delete the target comment

$(document).ready(function () 
 $("body").on("click",".delCommentLink",function (e) 
 e.preventDefault();
 var comment_url = $(e.target).parent().attr("href");
 var $commentEle = $(e.target).closest(".comment");
 if (window.confirm("Delete this comment?")) 
 $.ajax(
 type: "get",
 url: comment_url,
 success: function (data) 
 var ret = JSON.parse(data);
 if (ret['status'] == 1) 
 $commentEle.hide();
 else 
 alert(ret['msg']);
 ;
 ,//success
 );//ajax 
 else 
 e.preventDefault()
 
 );//click event
)

Click a link to delete it. My code seems like it has too many lines for such a routine task.

How can I complete it elegantly?

I only see two things to "reduce", regarding the line amount.

1. The if statement in the success callback could be replaced by a ternary operator.


2. 
   

   The last e.preventDefault() is redundant, you can squarely remove the whole else part.

   
   
   

   $(document).ready(function () 
    $("body").on("click",".delCommentLink",function (e) 
    e.preventDefault();
    var comment_url = $(e.target).parent().attr("href");
    var $commentEle = $(e.target).closest(".comment");
    if (window.confirm("Delete this comment?")) 
    $.ajax(
    type: "get",
    url: comment_url,
    success: function (data) 
    var ret = JSON.parse(data);
    (ret['status'] == 1) ? $commentEle.hide() : alert(ret['msg']);
    ,//success
    );//ajax 
    
    );//click event
   );
   

   
   

That is 6 lines less...