trjhtr

I built this 4 classes where the Main is the one responsible for setting and getting the variables. I am using PHP7.1. Please let me know on how to make this more amazing or maybe using trait. How does my classes look? Is it professionally made? what do you guys think? thank you very much!

<?php

class Main

 // Parameters
 protected $first_name;
 protected $middle_name;
 protected $last_name;

 public function first_name($first_name)
 
 $this->first_name = $first_name;
 return $this;
 

 public function middle_name($middle_name)
 
 $this->middle_name = $middle_name;
 return $this;
 

 public function last_name($last_name)
 
 $this->last_name = $last_name;
 return $this;
 


class Cpc extends Main

 public function __construct()
 
 echo 'this cpc construct <br>';
 

 public function generateCpc()
 
 echo 'this cpc generated <br>';
 echo $this->first_name." ".$this->middle_name." ".$this->last_name;
 echo '<br>';
 


class Basetable extends Cpc

 public function __construct()
 
 echo 'this basetable construct <br>';
 

 public function generateBasetable()
 
 echo 'this basetable generated <br>';
 echo $this->first_name." ".$this->middle_name." ".$this->last_name;
 echo '<br>';
 


class Layer extends Basetable

 public function __construct()
 
 echo 'this layer construct <br>';
 

 public function generateLayer()
 
 echo 'this layer generated <br>';
 echo $this->first_name." ".$this->middle_name." ".$this->last_name;
 echo '<br>';
 


class Master extends Layer

 public function __construct()
 
 echo 'this Master construct <br>';
 

 public function generate()
 
 $this->generateCpc();
 $this->generateBasetable();
 $this->generateLayer();

 echo 'this master generated <br>';
 echo $this->first_name." ".$this->middle_name." ".$this->last_name;
 echo '<br>';
 


$o = new Master();
$o->first_name('ken dan')->middle_name('sunico')->last_name('tinio')->generate();

?>

Basically, this structure makes very little sense by itself, without knowing the real purpose of all these classes and the similarities worth extending.

But some suggestions could be made anyway.

• whatever class that is intended to display some data, by definition cannot have a property like first name. First names are generally belong to persons. A class must represent a solid entity, not a Frankenstein constructed from different parts. So in your place I would avoid creating such entities as cyborgs, that bear both human-like and machine-like features. Whatever belongs to a person, goes to one class, and whatever belongs to a table renderer belongs to another class.


• There is a PHP coding standard, and you are supposed to follow its guidelines.

So, for as little information as provided in your question, here is a class structure I propose for you:

There is a class Person that holds the person's personal information,

class Person

 // Parameters
 protected $firstName;
 protected $middleName;
 protected $lastName;

 public function __construct($firstName, $middleName, $lastName)
 
 $this->firstName = $firstName;
 $this->middleName = $middleName;
 $this->lastName = $lastName;
 

 public function setFirstName($firstName)
 
 $this->firstName = $firstName;
 return $this;
 

 public function setMiddleName($middleName)
 
 $this->middleName = $middleName;
 return $this;
 

 public function setLastName($lastName)
 
 $this->lastName = $lastName;
 return $this;
 

 public function getFirstName()
 
 return $this->firstName;
 

 public function getMiddleName()
 
 return $this->middleName;
 

 public function getLastName()
 
 return $this->lastName;
 

and a class Output that renders tables.

class Output

 protected $person;

 public function __construct(Person $person)
 
 echo 'this Master construct <br>';
 $this->person = $person;
 

 protected function generateCpc()
 
 echo 'this cpc generated <br>';
 echo $this->person->getFirstName()." ".$this->person->getMiddleName()." ".$this->person->getLlast_name;
 echo '<br>';
 

 protected function generateBasetable()
 
 echo 'this basetable generated <br>';
 echo $this->person->getFirstName()." ".$this->person->getMiddleName()." ".$this->person->getLlast_name;
 echo '<br>';
 

 protected function generateLayer()
 
 echo 'this layer generated <br>';
 echo $this->person->getFirstName()." ".$this->person->getMiddleName()." ".$this->person->getLlast_name;
 echo '<br>';
 

 public function generate()
 
 $this->generateCpc();
 $this->generateBasetable();
 $this->generateLayer();

 echo 'this master generated <br>';
 echo $this->person->getFirstName()." ".$this->person->getMiddleName()." ".$this->person->getLlast_name;
 echo '<br>';
 

so it can be used like this

$output = new Output(new Person('ken dan', 'sunico', 'tinio'));
$output->generate();