trjhtr

I am trying to improve my test for a method that fetches all records from a DB and transforms them into API objects along with some business logic.

@Test
public void getAllUsers() throws Exception 

 final List<User> users = ImmutableList.of(
 new User(), new User()
 );

 final List<UserResponse> expected = ImmutableList.of(
 new UserResponse(), new UserResponse()
 );

 when(userDao.all()).thenReturn(users);
 when(mapper.map(new User())).thenReturn(new UserResponse());
 assertEquals(expected, this.userService.getAllUsers());

At the moment I have two lists filled will empty objects.

Is there a better way to initialise a list with dummy data, without having to explicitly build each object in the list with code?

Code under test

public List<UserResponse> getAllUsers() throws UserServiceException 

 try 
 return this.userDao.all()
 .stream()
 .map(mapper::map)
 .collect(Collectors.toList());
 catch (SQLException e) 
 throw new UserServiceException(e.getMessage());
 

Also are there any other checks I should be doing at this point?

Note: the mapper class is tested separately