Sorting a list of IComparables

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
1
down vote

favorite












I have a DateTime class (my own, not System.DateTime) which implements IComparable.



Here is a method that takes a List<DateTime> and sorts it:



private List<DateTime> SortDateTimes(List<DateTime> dateTimes)

 for (int i = 0; i < dateTimes.Count; i++)
 
 for (int j = 0; j < dateTimes.Count; j++)
 
 if (dateTimes[i] < dateTimes[j])
 
 var temp = dateTimes[i];
 dateTimes[i] = dateTimes[j];
 dateTimes[j] = temp;
 
 
 

 return dateTimes;



I believe using foreach loops instead of for is suitable here, but having the following variable names drives me crazy. :D



foreach(var dateTime1 in dateTimes)
{
 foreach(var dateTime2 in datetimes)
 ...


What are your thoughts?
Thanks!




c# sorting




share|improve this question

















  • 6




    This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
    – VisualMelon
    Feb 5 at 18:24











  • Hmm, as said above: stackoverflow.com/questions/26868600/…
    – Ï€Î¬Î½Ï„α ῥεῖ
    Feb 5 at 18:25










  • @VisualMelon so all I need to do is dateTimes.Sort()?
    – Sipo
    Feb 5 at 18:27










  • @Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
    – VisualMelon
    Feb 5 at 18:28







  • 3




    I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
    – VisualMelon
    Feb 5 at 18:37

















up vote
1
down vote

favorite












I have a DateTime class (my own, not System.DateTime) which implements IComparable.



Here is a method that takes a List<DateTime> and sorts it:



private List<DateTime> SortDateTimes(List<DateTime> dateTimes)

 for (int i = 0; i < dateTimes.Count; i++)
 
 for (int j = 0; j < dateTimes.Count; j++)
 
 if (dateTimes[i] < dateTimes[j])
 
 var temp = dateTimes[i];
 dateTimes[i] = dateTimes[j];
 dateTimes[j] = temp;
 
 
 

 return dateTimes;



I believe using foreach loops instead of for is suitable here, but having the following variable names drives me crazy. :D



foreach(var dateTime1 in dateTimes)
{
 foreach(var dateTime2 in datetimes)
 ...


What are your thoughts?
Thanks!




c# sorting




share|improve this question

















  • 6




    This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
    – VisualMelon
    Feb 5 at 18:24











  • Hmm, as said above: stackoverflow.com/questions/26868600/…
    – Ï€Î¬Î½Ï„α ῥεῖ
    Feb 5 at 18:25










  • @VisualMelon so all I need to do is dateTimes.Sort()?
    – Sipo
    Feb 5 at 18:27










  • @Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
    – VisualMelon
    Feb 5 at 18:28







  • 3




    I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
    – VisualMelon
    Feb 5 at 18:37













up vote
1
down vote

favorite









up vote
1
down vote

favorite











I have a DateTime class (my own, not System.DateTime) which implements IComparable.



Here is a method that takes a List<DateTime> and sorts it:



private List<DateTime> SortDateTimes(List<DateTime> dateTimes)

 for (int i = 0; i < dateTimes.Count; i++)
 
 for (int j = 0; j < dateTimes.Count; j++)
 
 if (dateTimes[i] < dateTimes[j])
 
 var temp = dateTimes[i];
 dateTimes[i] = dateTimes[j];
 dateTimes[j] = temp;
 
 
 

 return dateTimes;



I believe using foreach loops instead of for is suitable here, but having the following variable names drives me crazy. :D



foreach(var dateTime1 in dateTimes)
{
 foreach(var dateTime2 in datetimes)
 ...


What are your thoughts?
Thanks!




c# sorting




share|improve this question













I have a DateTime class (my own, not System.DateTime) which implements IComparable.



Here is a method that takes a List<DateTime> and sorts it:



private List<DateTime> SortDateTimes(List<DateTime> dateTimes)

 for (int i = 0; i < dateTimes.Count; i++)
 
 for (int j = 0; j < dateTimes.Count; j++)
 
 if (dateTimes[i] < dateTimes[j])
 
 var temp = dateTimes[i];
 dateTimes[i] = dateTimes[j];
 dateTimes[j] = temp;
 
 
 

 return dateTimes;



I believe using foreach loops instead of for is suitable here, but having the following variable names drives me crazy. :D



foreach(var dateTime1 in dateTimes)
{
 foreach(var dateTime2 in datetimes)
 ...


What are your thoughts?
Thanks!





c# sorting





share|improve this question












share|improve this question




share|improve this question








edited Feb 5 at 18:26
























asked Feb 5 at 18:13









Sipo

1414




1414







  • 6




    This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
    – VisualMelon
    Feb 5 at 18:24











  • Hmm, as said above: stackoverflow.com/questions/26868600/…
    – Ï€Î¬Î½Ï„α ῥεῖ
    Feb 5 at 18:25










  • @VisualMelon so all I need to do is dateTimes.Sort()?
    – Sipo
    Feb 5 at 18:27










  • @Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
    – VisualMelon
    Feb 5 at 18:28







  • 3




    I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
    – VisualMelon
    Feb 5 at 18:37













  • 6




    This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
    – VisualMelon
    Feb 5 at 18:24











  • Hmm, as said above: stackoverflow.com/questions/26868600/…
    – Ï€Î¬Î½Ï„α ῥεῖ
    Feb 5 at 18:25










  • @VisualMelon so all I need to do is dateTimes.Sort()?
    – Sipo
    Feb 5 at 18:27










  • @Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
    – VisualMelon
    Feb 5 at 18:28







  • 3




    I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
    – VisualMelon
    Feb 5 at 18:37








6




6




This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
– VisualMelon
Feb 5 at 18:24





This doesn't have a 'reinventing the wheel tag'...: have you considered using List.Sort? Here you have provided a something not far off a (comparatively poor, since it lacks a cutoff) bubble sort, which will take n^2 steps to sort your list, where n is the number of items in the list. An 'efficient' sorting algorithm (as List.Sort will use) will do the same job in n log(n) steps, which is big difference for a large n.
– VisualMelon
Feb 5 at 18:24













Hmm, as said above: stackoverflow.com/questions/26868600/…
– Ï€Î¬Î½Ï„α ῥεῖ
Feb 5 at 18:25




Hmm, as said above: stackoverflow.com/questions/26868600/…
– Ï€Î¬Î½Ï„α ῥεῖ
Feb 5 at 18:25












@VisualMelon so all I need to do is dateTimes.Sort()?
– Sipo
Feb 5 at 18:27




@VisualMelon so all I need to do is dateTimes.Sort()?
– Sipo
Feb 5 at 18:27












@Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
– VisualMelon
Feb 5 at 18:28





@Sipo yeah, I think so. (It's a bit of a weird method, because it looks at the type (in runtime) to work out if it can sort it, part of which involves checking if it is IComparable; there are ways to make it more 'concrete')
– VisualMelon
Feb 5 at 18:28





3




3




I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
– VisualMelon
Feb 5 at 18:37





I'm not sure it would qualify as an answer (since it isn't really about your code)... just have a quick read of the Remarks for List<T>.Sort which details how the DefaultComparer<T> is prepared. As long as you don't try to do anything silly with it, nothing will go wrong, and if you do try to do something silly with it then it will tell you by throwing an exception.
– VisualMelon
Feb 5 at 18:37
















active

oldest

votes











Your Answer




StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: false,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);








 

draft saved


draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f186858%2fsorting-a-list-of-icomparables%23new-answer', 'question_page');

);

Post as a guest






















active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes










 

draft saved


draft discarded


























 


draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f186858%2fsorting-a-list-of-icomparables%23new-answer', 'question_page');

);

Post as a guest
































































-

Popular posts from this blog

Chat program with C++ and SFML

Image
Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 2 down vote favorite This is my client code: (My server is very similar at the moment but I will upload it below this one just in case somebody wants to run it) #include <SFML/Graphics.hpp> #include <SFML/Network.hpp> #include <thread> int main() sf::RenderWindow main_win(sf::VideoMode(800, 800), "Chatcy!"); main_win.setPosition(sf::Vector2i(sf::VideoMode::getDesktopMode().width/2 -400, sf::VideoMode::getDesktopMode().height/2 -400)); main_win.setVerticalSyncEnabled(true); //chatcy logo sf::Texture chatcy; chatcy.loadFromFile("image_chatcy.png"); sf::Sprite logo; logo.setTexture(chatcy); //200x800 //font sf::Font font; font.loadFromFile("FreeSerif.ttf"); //name sf::String name("Client"); name += ": "; //text input area and background sf::RectangleShape in_backg
Read more

Function to Return a JSON Like Objects Using VBA Collections and Arrays

Image
Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 1 down vote favorite My goal is to create a compact function that can create a JSON Like object from JSON string. I want a function with a small footprint that I or anyone who wants to use it, can simply paste into a module and use. At 61 lines of code, I am happy with its size and portability. Here is an image of JSON Object created from string data using a ScriptControl . Although the Locals Window displays the properties and values correctly, the object itself is extremely difficult to work with. This image shows an object created using getJSONCollection . Because it is made of VBA Collections and Arrays, it is very easy to work with. Option Explicit Private Function getJSONCollection(ByVal Value As Variant, Optional ScriptEngine As Object) As Variant Const DELIMITER As String = "||" Dim col As Collection, JSON As Object, KeyNam
Read more

Will my employers contract hold up in court?

Image
Clash Royale CLAN TAG #URR8PPP up vote 8 down vote favorite 2 When I started a new job back in July of 2017, I signed a contract that had the following bindings or restrictions if I was ever to leave the company: Cannot work for a competitor within 25 miles of current companies location for the next two years Cannot offer my services to any organization within 25 miles of current companies location for the next two years Now, when mentioned “my services” this can be related to my profession of website design. This contract seems incredibly binding, 2 years in length, and I’m looking to see if it would actually hold up in an Arizona court. contract employment non-compete arizona share | improve this question edited Aug 7 at 15:35 feetwet ♦ 13.8k 9 37 85 asked Aug 6 at 19:05 Alex S. 46 2 What does your company do and what services do they provide? What is your role (i.e. internal work or work for customers).
Read more