trjhtr

I need to filter database data based on filters available to the end user in the form of search term text box, select boxes etc.

I have put together this code and need feedback if this is a good way to do it or if there are any better solutions.

using Multi.Model;
using System;
using System.Linq;
using System.Windows.Controls;

namespace Multi.Pages

 /// <summary>
 /// Interaction logic for Page1.xaml
 /// </summary>
 public partial class Page1 : Page
 

 public Page1()
 
 InitializeComponent();
 textBoxName.TextChanged += TextBoxName_TextChanged;
 PopulateDataGrid();
 

 private void PopulateDataGrid()
 
 using (var db = new optisysEntities())
 
 var items = db.clients.AsQueryable();
 items = FilterClients(db, items);
 dataGrid.ItemsSource = items.ToList();
 
 

 private System.Linq.IQueryable<Multi.Model.clients> FilterClients(optisysEntities db, System.Linq.IQueryable<Multi.Model.clients> clients)
 c.phone.Contains(textBoxName.Text));
 // if (!String.IsNullOrWhiteSpace(search.Email)) clients = clients.Where(u => u.Email.Contains(search.Email));
 // if (search.UsertypeId.HasValue) clients = clients.Where(u => u.UsertypeId == search.UsertypeId.Value);
 return clients;
 

 private void TextBoxName_TextChanged(object sender, TextChangedEventArgs e)
 
 PopulateDataGrid();
 

 

Reducing your code to what I think is the core of your question:

private System.Linq.IQueryable<Multi.Model.clients> FilterClients(optisysEntities db, System.Linq.IQueryable<Multi.Model.clients> clients)

Yes, this is one of the better ways to do dynamic filtering.

I would suggest abstracting the data retrieval into a separate layer. You don't want your form logic handling your underlying ORM directly.

This is exacerbated by the fact that you've put the FilterClients() method by itself. Your UI form therefore contains a method whose reponsibility has nothing to do with the UI.

However, I get the feeling that this application is either tiny, or has only just been developed. So I can understand that this abstraction is something for a later stage. I would suggest doing it immediately to make it less painful in the future, but that's your choice.