trjhtr

So i am working on a project and my question is as follows. In the code below is alot of code duplication going. Is it possible to avoid code duplication in such cases? What would be the best practices to avoid the code duplication below. I hope someone can point me to the right direction.

public void rechts() 
 openBarricade(veld, 1, 0);
 int x = locatie[0] / 50;
 int y = locatie[1] / 50;
 if (x < 9 && veld.getVak(x + 1, y).isLoopbaar()) 
 switch (frame) 
 case 0:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_r1.png")).getImage());
 frame++;
 break;
 case 1:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_r2.png")).getImage());
 frame++;
 break;
 case 2:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_r3.png")).getImage());
 frame++;
 break;
 default:
 frame = 0;
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_r2.png")).getImage());
 break;
 
 lopen(UI.OBJECTBREEDTE, 0);
 

 

 public void links() 
 openBarricade(veld, -1, 0);
 int x = locatie[0] / 50;
 int y = locatie[1] / 50;

 if (x > 0 && veld.getVak(x - 1, y).isLoopbaar()) 
 switch (frame) 
 case 0:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_l1.png")).getImage());
 frame++;
 break;
 case 1:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_l2.png")).getImage());
 frame++;
 break;
 case 2:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_l3.png")).getImage());
 frame++;
 break;
 default:
 frame = 0;
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_l2.png")).getImage());
 break;
 
 lopen(-UI.OBJECTBREEDTE, 0);

 

 

 public void omHoog() 
 openBarricade(veld, 0, -1);
 int x = locatie[0] / 50;
 int y = locatie[1] / 50;

 if (y > 0 && veld.getVak(x, y - 1).isLoopbaar()) 
 switch (frame) 
 case 0:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_u1.png")).getImage());
 frame++;
 break;
 case 1:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_u2.png")).getImage());
 frame++;
 break;
 case 2:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_u3.png")).getImage());
 frame++;
 break;
 default:
 frame = 0;
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_u2.png")).getImage());
 break;
 
 lopen(0, -UI.OBJECTBREEDTE);

 
 

 public void omLaag() 
 openBarricade(veld, 0, 1);
 int x = locatie[0] / 50;
 int y = locatie[1] / 50;

 if (y < 9 && veld.getVak(x, y + 1).isLoopbaar()) 
 switch (frame) 
 case 0:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_d1.png")).getImage());
 frame++;
 break;
 case 1:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_d2.png")).getImage());
 frame++;
 break;
 case 2:
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_d3.png")).getImage());
 frame++;
 break;
 default:
 frame = 0;
 setImage(new ImageIcon(getClass().getResource("/images/speler/speler_d2.png")).getImage());
 break;
 

 lopen(0, UI.OBJECTBREEDTE);

 
 

here is what I did:
I focused on the switch statements since it seems they are almost identical. it turns out they differ in one letter in the resource name. So it makes sense to create a method that recevies this letter. There is also duplication in the case clauses, so I replaced the switch with an if that separates default clause from the rest:

public void commonSetImage(String spelerLetter) 
 // default values
 int resourceNum = 2;
 String resource = String.format("/images/speler/speler_%s%d.png", spelerLetter, resourceNum);
 // in case frame is between 0 to 2, set resource num according to frame
 if (frame >= 0 && frame <= 2) 
 resourceNum = frame + 1;
 resource = String.format("/images/speler/speler_%s%d.png", spelerLetter, resourceNum);
 setImage(new ImageIcon(getClass().getResource(resource)).getImage());
 frame++;
 else 
 frame = 0;
 setImage(new ImageIcon(getClass().getResource(resource)).getImage());
 

now the original methods can make use of the new method:

public void rechts() 
 openBarricade(veld, 1, 0);
 int x = locatie[0] / 50;
 int y = locatie[1] / 50;
 if (x < 9 && veld.getVak(x + 1, y).isLoopbaar()) 
 commonSetImage("r");
 lopen(UI.OBJECTBREEDTE, 0);