jQuery animation tab slider

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
2
down vote

favorite












I'm a beginner in js and jQuery. I wrote animation tab-slider. But my code is bad. What should I improve? What should I do to make the code less cumbersome?






var slideTabImg = $('.js-slide-tabImg');
var firstTab = $('#js-first-tabImg');
var secondTab = $('#js-second-tabImg');

$('#js-first-tab').click(function()
 $(this).next().removeClass('m-slideTa href');
 $(this).addClass('m-slideTab-href');

 slideTabImg.removeClass('m-slide-tabImg_active');
 slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

 secondTab.addClass('m-secondTab-active');
 firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
);

$('#js-second-tab').click(function()
		$(this).prev().removeClass('m-slideTab-href');
		$(this).addClass('m-slideTab-href');

 	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
		slideTabImg.removeClass('m-slide-tabImg_active');
		
		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
		firstTab.addClass('m-secondTab-active');
);

.slide-tabImages 
	position: relative;
	width: 100%;
	max-width: 860px;
	margin: 0 auto;

.slide-tabImg 
	position: absolute;

.m-slide-tabImg_active 
	top: 40px;
	left: -40px;
	z-index: 5

.slide-tab 
	padding: 30px 0;

.slideTab-href 
	font-size: 20px;
	color: #000;
	text-transform: uppercase;
	font-weight: normal;
	cursor: pointer;
	margin: 0 8px;

.slideTab-href:hover 
	text-decoration: none;

.slideTabLink 
	padding-top: 80px;

.m-slideTab-href 
	border-bottom: 1px dashed;
 

.m-secondTab-active 
 animation: secondTab-animation 2.5s forwards;


.m-firstTab-active 
 animation: firstTab-animation 2.5s forwards;


@keyframes secondTab-animation 
 49% 
 transform: translateX(-120px);
 
 
 to 
 transform: translateX(0);
 z-index: 1;
 


@keyframes firstTab-animation 
 49% 
 transform: translateX(120px);
 
 
 to 
 transform: translateX(0);
 

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

<div class=" slideTabLink">
	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
	<a id="js-second-tab" class=" slideTab-href">Old</a>
</div>
			
<div class=" slide-tab js-slide-tab">
	<div class=" slide-tabImages">
	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
		</div>
		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
		</div>
	</div>
</div>






javascript jquery




share|improve this question

























    up vote
    2
    down vote

    favorite












    I'm a beginner in js and jQuery. I wrote animation tab-slider. But my code is bad. What should I improve? What should I do to make the code less cumbersome?






    var slideTabImg = $('.js-slide-tabImg');
    var firstTab = $('#js-first-tabImg');
    var secondTab = $('#js-second-tabImg');

    $('#js-first-tab').click(function()
     $(this).next().removeClass('m-slideTa href');
     $(this).addClass('m-slideTab-href');

     slideTabImg.removeClass('m-slide-tabImg_active');
     slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

     secondTab.addClass('m-secondTab-active');
     firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
    );

    $('#js-second-tab').click(function()
    		$(this).prev().removeClass('m-slideTab-href');
    		$(this).addClass('m-slideTab-href');

     	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
    		slideTabImg.removeClass('m-slide-tabImg_active');
    		
    		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
    		firstTab.addClass('m-secondTab-active');
    );

    .slide-tabImages 
    	position: relative;
    	width: 100%;
    	max-width: 860px;
    	margin: 0 auto;

    .slide-tabImg 
    	position: absolute;

    .m-slide-tabImg_active 
    	top: 40px;
    	left: -40px;
    	z-index: 5

    .slide-tab 
    	padding: 30px 0;

    .slideTab-href 
    	font-size: 20px;
    	color: #000;
    	text-transform: uppercase;
    	font-weight: normal;
    	cursor: pointer;
    	margin: 0 8px;

    .slideTab-href:hover 
    	text-decoration: none;

    .slideTabLink 
    	padding-top: 80px;

    .m-slideTab-href 
    	border-bottom: 1px dashed;
     

    .m-secondTab-active 
     animation: secondTab-animation 2.5s forwards;


    .m-firstTab-active 
     animation: firstTab-animation 2.5s forwards;


    @keyframes secondTab-animation 
     49% 
     transform: translateX(-120px);
     
     
     to 
     transform: translateX(0);
     z-index: 1;
     


    @keyframes firstTab-animation 
     49% 
     transform: translateX(120px);
     
     
     to 
     transform: translateX(0);
     

    <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

    <div class=" slideTabLink">
    	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
    	<a id="js-second-tab" class=" slideTab-href">Old</a>
    </div>
    			
    <div class=" slide-tab js-slide-tab">
    	<div class=" slide-tabImages">
    	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
    			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
    		</div>
    		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
    			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
    		</div>
    	</div>
    </div>






    javascript jquery




    share|improve this question





















      up vote
      2
      down vote

      favorite









      up vote
      2
      down vote

      favorite











      I'm a beginner in js and jQuery. I wrote animation tab-slider. But my code is bad. What should I improve? What should I do to make the code less cumbersome?






      var slideTabImg = $('.js-slide-tabImg');
      var firstTab = $('#js-first-tabImg');
      var secondTab = $('#js-second-tabImg');

      $('#js-first-tab').click(function()
       $(this).next().removeClass('m-slideTa href');
       $(this).addClass('m-slideTab-href');

       slideTabImg.removeClass('m-slide-tabImg_active');
       slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

       secondTab.addClass('m-secondTab-active');
       firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
      );

      $('#js-second-tab').click(function()
      		$(this).prev().removeClass('m-slideTab-href');
      		$(this).addClass('m-slideTab-href');

       	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
      		slideTabImg.removeClass('m-slide-tabImg_active');
      		
      		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
      		firstTab.addClass('m-secondTab-active');
      );

      .slide-tabImages 
      	position: relative;
      	width: 100%;
      	max-width: 860px;
      	margin: 0 auto;

      .slide-tabImg 
      	position: absolute;

      .m-slide-tabImg_active 
      	top: 40px;
      	left: -40px;
      	z-index: 5

      .slide-tab 
      	padding: 30px 0;

      .slideTab-href 
      	font-size: 20px;
      	color: #000;
      	text-transform: uppercase;
      	font-weight: normal;
      	cursor: pointer;
      	margin: 0 8px;

      .slideTab-href:hover 
      	text-decoration: none;

      .slideTabLink 
      	padding-top: 80px;

      .m-slideTab-href 
      	border-bottom: 1px dashed;
       

      .m-secondTab-active 
       animation: secondTab-animation 2.5s forwards;


      .m-firstTab-active 
       animation: firstTab-animation 2.5s forwards;


      @keyframes secondTab-animation 
       49% 
       transform: translateX(-120px);
       
       
       to 
       transform: translateX(0);
       z-index: 1;
       


      @keyframes firstTab-animation 
       49% 
       transform: translateX(120px);
       
       
       to 
       transform: translateX(0);
       

      <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

      <div class=" slideTabLink">
      	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
      	<a id="js-second-tab" class=" slideTab-href">Old</a>
      </div>
      			
      <div class=" slide-tab js-slide-tab">
      	<div class=" slide-tabImages">
      	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
      		</div>
      		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
      		</div>
      	</div>
      </div>






      javascript jquery




      share|improve this question











      I'm a beginner in js and jQuery. I wrote animation tab-slider. But my code is bad. What should I improve? What should I do to make the code less cumbersome?






      var slideTabImg = $('.js-slide-tabImg');
      var firstTab = $('#js-first-tabImg');
      var secondTab = $('#js-second-tabImg');

      $('#js-first-tab').click(function()
       $(this).next().removeClass('m-slideTa href');
       $(this).addClass('m-slideTab-href');

       slideTabImg.removeClass('m-slide-tabImg_active');
       slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

       secondTab.addClass('m-secondTab-active');
       firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
      );

      $('#js-second-tab').click(function()
      		$(this).prev().removeClass('m-slideTab-href');
      		$(this).addClass('m-slideTab-href');

       	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
      		slideTabImg.removeClass('m-slide-tabImg_active');
      		
      		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
      		firstTab.addClass('m-secondTab-active');
      );

      .slide-tabImages 
      	position: relative;
      	width: 100%;
      	max-width: 860px;
      	margin: 0 auto;

      .slide-tabImg 
      	position: absolute;

      .m-slide-tabImg_active 
      	top: 40px;
      	left: -40px;
      	z-index: 5

      .slide-tab 
      	padding: 30px 0;

      .slideTab-href 
      	font-size: 20px;
      	color: #000;
      	text-transform: uppercase;
      	font-weight: normal;
      	cursor: pointer;
      	margin: 0 8px;

      .slideTab-href:hover 
      	text-decoration: none;

      .slideTabLink 
      	padding-top: 80px;

      .m-slideTab-href 
      	border-bottom: 1px dashed;
       

      .m-secondTab-active 
       animation: secondTab-animation 2.5s forwards;


      .m-firstTab-active 
       animation: firstTab-animation 2.5s forwards;


      @keyframes secondTab-animation 
       49% 
       transform: translateX(-120px);
       
       
       to 
       transform: translateX(0);
       z-index: 1;
       


      @keyframes firstTab-animation 
       49% 
       transform: translateX(120px);
       
       
       to 
       transform: translateX(0);
       

      <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

      <div class=" slideTabLink">
      	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
      	<a id="js-second-tab" class=" slideTab-href">Old</a>
      </div>
      			
      <div class=" slide-tab js-slide-tab">
      	<div class=" slide-tabImages">
      	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
      		</div>
      		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
      		</div>
      	</div>
      </div>








      var slideTabImg = $('.js-slide-tabImg');
      var firstTab = $('#js-first-tabImg');
      var secondTab = $('#js-second-tabImg');

      $('#js-first-tab').click(function()
       $(this).next().removeClass('m-slideTa href');
       $(this).addClass('m-slideTab-href');

       slideTabImg.removeClass('m-slide-tabImg_active');
       slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

       secondTab.addClass('m-secondTab-active');
       firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
      );

      $('#js-second-tab').click(function()
      		$(this).prev().removeClass('m-slideTab-href');
      		$(this).addClass('m-slideTab-href');

       	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
      		slideTabImg.removeClass('m-slide-tabImg_active');
      		
      		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
      		firstTab.addClass('m-secondTab-active');
      );

      .slide-tabImages 
      	position: relative;
      	width: 100%;
      	max-width: 860px;
      	margin: 0 auto;

      .slide-tabImg 
      	position: absolute;

      .m-slide-tabImg_active 
      	top: 40px;
      	left: -40px;
      	z-index: 5

      .slide-tab 
      	padding: 30px 0;

      .slideTab-href 
      	font-size: 20px;
      	color: #000;
      	text-transform: uppercase;
      	font-weight: normal;
      	cursor: pointer;
      	margin: 0 8px;

      .slideTab-href:hover 
      	text-decoration: none;

      .slideTabLink 
      	padding-top: 80px;

      .m-slideTab-href 
      	border-bottom: 1px dashed;
       

      .m-secondTab-active 
       animation: secondTab-animation 2.5s forwards;


      .m-firstTab-active 
       animation: firstTab-animation 2.5s forwards;


      @keyframes secondTab-animation 
       49% 
       transform: translateX(-120px);
       
       
       to 
       transform: translateX(0);
       z-index: 1;
       


      @keyframes firstTab-animation 
       49% 
       transform: translateX(120px);
       
       
       to 
       transform: translateX(0);
       

      <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

      <div class=" slideTabLink">
      	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
      	<a id="js-second-tab" class=" slideTab-href">Old</a>
      </div>
      			
      <div class=" slide-tab js-slide-tab">
      	<div class=" slide-tabImages">
      	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
      		</div>
      		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
      		</div>
      	</div>
      </div>





      var slideTabImg = $('.js-slide-tabImg');
      var firstTab = $('#js-first-tabImg');
      var secondTab = $('#js-second-tabImg');

      $('#js-first-tab').click(function()
       $(this).next().removeClass('m-slideTa href');
       $(this).addClass('m-slideTab-href');

       slideTabImg.removeClass('m-slide-tabImg_active');
       slideTabImg.removeClass('m-secondTab-active m-firstTab-active');

       secondTab.addClass('m-secondTab-active');
       firstTab.addClass('m-slide-tabImg_active m-firstTab-active');
      );

      $('#js-second-tab').click(function()
      		$(this).prev().removeClass('m-slideTab-href');
      		$(this).addClass('m-slideTab-href');

       	slideTabImg.removeClass('m-secondTab-active m-firstTab-active');
      		slideTabImg.removeClass('m-slide-tabImg_active');
      		
      		secondTab.addClass('m-slide-tabImg_active m-firstTab-active');
      		firstTab.addClass('m-secondTab-active');
      );

      .slide-tabImages 
      	position: relative;
      	width: 100%;
      	max-width: 860px;
      	margin: 0 auto;

      .slide-tabImg 
      	position: absolute;

      .m-slide-tabImg_active 
      	top: 40px;
      	left: -40px;
      	z-index: 5

      .slide-tab 
      	padding: 30px 0;

      .slideTab-href 
      	font-size: 20px;
      	color: #000;
      	text-transform: uppercase;
      	font-weight: normal;
      	cursor: pointer;
      	margin: 0 8px;

      .slideTab-href:hover 
      	text-decoration: none;

      .slideTabLink 
      	padding-top: 80px;

      .m-slideTab-href 
      	border-bottom: 1px dashed;
       

      .m-secondTab-active 
       animation: secondTab-animation 2.5s forwards;


      .m-firstTab-active 
       animation: firstTab-animation 2.5s forwards;


      @keyframes secondTab-animation 
       49% 
       transform: translateX(-120px);
       
       
       to 
       transform: translateX(0);
       z-index: 1;
       


      @keyframes firstTab-animation 
       49% 
       transform: translateX(120px);
       
       
       to 
       transform: translateX(0);
       

      <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>

      <div class=" slideTabLink">
      	<a id="js-first-tab" class=" slideTab-href m-slideTab-href">New</a>
      	<a id="js-second-tab" class=" slideTab-href">Old</a>
      </div>
      			
      <div class=" slide-tab js-slide-tab">
      	<div class=" slide-tabImages">
      	<div class=" slide-tabImg m-slide-tabImg_active js-slide-tabImg" id="js-first-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb68da321d060058111.png" alt="">
      		</div>
      		<div class=" slide-tabImg js-slide-tabImg" id="js-second-tabImg">
      			<img src="https://habrastorage.org/webt/5a/fe/b6/5afeb6aea3f83085649799.png" alt="">
      		</div>
      	</div>
      </div>




      javascript jquery





      share|improve this question










      share|improve this question




      share|improve this question









      asked May 21 at 9:37









      Wexzuq

      111




      111

























          active

          oldest

          votes











          Your Answer




          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: false,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );








           

          draft saved


          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f194857%2fjquery-animation-tab-slider%23new-answer', 'question_page');

          );

          Post as a guest






















          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes










           

          draft saved


          draft discarded


























           


          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f194857%2fjquery-animation-tab-slider%23new-answer', 'question_page');

          );

          Post as a guest
































































          -

          Popular posts from this blog

          Chat program with C++ and SFML

          Image
          Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 2 down vote favorite This is my client code: (My server is very similar at the moment but I will upload it below this one just in case somebody wants to run it) #include <SFML/Graphics.hpp> #include <SFML/Network.hpp> #include <thread> int main() sf::RenderWindow main_win(sf::VideoMode(800, 800), "Chatcy!"); main_win.setPosition(sf::Vector2i(sf::VideoMode::getDesktopMode().width/2 -400, sf::VideoMode::getDesktopMode().height/2 -400)); main_win.setVerticalSyncEnabled(true); //chatcy logo sf::Texture chatcy; chatcy.loadFromFile("image_chatcy.png"); sf::Sprite logo; logo.setTexture(chatcy); //200x800 //font sf::Font font; font.loadFromFile("FreeSerif.ttf"); //name sf::String name("Client"); name += ": "; //text input area and background sf::RectangleShape in_backg...
          Read more

          Function to Return a JSON Like Objects Using VBA Collections and Arrays

          Image
          Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 1 down vote favorite My goal is to create a compact function that can create a JSON Like object from JSON string. I want a function with a small footprint that I or anyone who wants to use it, can simply paste into a module and use. At 61 lines of code, I am happy with its size and portability. Here is an image of JSON Object created from string data using a ScriptControl . Although the Locals Window displays the properties and values correctly, the object itself is extremely difficult to work with. This image shows an object created using getJSONCollection . Because it is made of VBA Collections and Arrays, it is very easy to work with. Option Explicit Private Function getJSONCollection(ByVal Value As Variant, Optional ScriptEngine As Object) As Variant Const DELIMITER As String = "||" Dim col As Collection, JSON As Object, KeyNam...
          Read more

          Will my employers contract hold up in court?

          Image
          Clash Royale CLAN TAG #URR8PPP up vote 8 down vote favorite 2 When I started a new job back in July of 2017, I signed a contract that had the following bindings or restrictions if I was ever to leave the company: Cannot work for a competitor within 25 miles of current companies location for the next two years Cannot offer my services to any organization within 25 miles of current companies location for the next two years Now, when mentioned “my services” this can be related to my profession of website design. This contract seems incredibly binding, 2 years in length, and I’m looking to see if it would actually hold up in an Arizona court. contract employment non-compete arizona share | improve this question edited Aug 7 at 15:35 feetwet ♦ 13.8k 9 37 85 asked Aug 6 at 19:05 Alex S. 46 2 What does your comp...
          Read more