Image slider code

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
2
down vote

favorite












I've been doing this image slider section, I've been working on this code for quite a time, the code is perfectly working but I want to improve it.



I tried for hours and couldn't find a way. Maybe because I'm too in my code that I can't see other better options.



Can you guys suggest me a better way to improve my code?



let $roller = $('#management_roller .manage-roller');
let rollerChild = $roller.children();
let childNumber = rollerChild.length;
let number = 0;

const getTranslteX = () => matrix[4]

const howBig = () =>
const windowW = window.innerWidth;
if(windowW <= 576)
return 1;
else if(windowW <= 768)
return 2;
else if(windowW <= 1200)
return 3;
else
return 4;




const setX = (n) =>
$roller.css('transform' : 'translateX(-' + n +'px)');




$('#roller_links a').click(function(e)
e.preventDefault();

$('#roller_links a').removeClass('active');
const id = $(this).attr('id');
const rollerP = $roller.parent();

$(this).addClass('active');
rollerP.hide();
$roller = $('#' + id + '_roller .manage-roller');
rollerChild = $roller.children();
number = 0;
$roller.parent().show();
setX(number * $(rollerChild[number]).outerWidth());
);



$('#roller-n').click(function()
if(childNumber - howBig() === number) return;
number++;
setX(getTranslteX() +
$(rollerChild[number]).outerWidth());
);

$('#roller-p').click(function()
if(number === 0) return;
number--;
setX(Math.abs(getTranslteX() -
$(rollerChild[number]).outerWidth()));
);


$(window).on('resize', function()
if(childNumber - howBig() < number) number =
childNumber - howBig();
setX(number * $(rollerChild[number]).outerWidth());
);






share|improve this question





















  • Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
    – Sam Onela
    Mar 22 at 5:50
















up vote
2
down vote

favorite












I've been doing this image slider section, I've been working on this code for quite a time, the code is perfectly working but I want to improve it.



I tried for hours and couldn't find a way. Maybe because I'm too in my code that I can't see other better options.



Can you guys suggest me a better way to improve my code?



let $roller = $('#management_roller .manage-roller');
let rollerChild = $roller.children();
let childNumber = rollerChild.length;
let number = 0;

const getTranslteX = () => matrix[4]

const howBig = () =>
const windowW = window.innerWidth;
if(windowW <= 576)
return 1;
else if(windowW <= 768)
return 2;
else if(windowW <= 1200)
return 3;
else
return 4;




const setX = (n) =>
$roller.css('transform' : 'translateX(-' + n +'px)');




$('#roller_links a').click(function(e)
e.preventDefault();

$('#roller_links a').removeClass('active');
const id = $(this).attr('id');
const rollerP = $roller.parent();

$(this).addClass('active');
rollerP.hide();
$roller = $('#' + id + '_roller .manage-roller');
rollerChild = $roller.children();
number = 0;
$roller.parent().show();
setX(number * $(rollerChild[number]).outerWidth());
);



$('#roller-n').click(function()
if(childNumber - howBig() === number) return;
number++;
setX(getTranslteX() +
$(rollerChild[number]).outerWidth());
);

$('#roller-p').click(function()
if(number === 0) return;
number--;
setX(Math.abs(getTranslteX() -
$(rollerChild[number]).outerWidth()));
);


$(window).on('resize', function()
if(childNumber - howBig() < number) number =
childNumber - howBig();
setX(number * $(rollerChild[number]).outerWidth());
);






share|improve this question





















  • Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
    – Sam Onela
    Mar 22 at 5:50












up vote
2
down vote

favorite









up vote
2
down vote

favorite











I've been doing this image slider section, I've been working on this code for quite a time, the code is perfectly working but I want to improve it.



I tried for hours and couldn't find a way. Maybe because I'm too in my code that I can't see other better options.



Can you guys suggest me a better way to improve my code?



let $roller = $('#management_roller .manage-roller');
let rollerChild = $roller.children();
let childNumber = rollerChild.length;
let number = 0;

const getTranslteX = () => matrix[4]

const howBig = () =>
const windowW = window.innerWidth;
if(windowW <= 576)
return 1;
else if(windowW <= 768)
return 2;
else if(windowW <= 1200)
return 3;
else
return 4;




const setX = (n) =>
$roller.css('transform' : 'translateX(-' + n +'px)');




$('#roller_links a').click(function(e)
e.preventDefault();

$('#roller_links a').removeClass('active');
const id = $(this).attr('id');
const rollerP = $roller.parent();

$(this).addClass('active');
rollerP.hide();
$roller = $('#' + id + '_roller .manage-roller');
rollerChild = $roller.children();
number = 0;
$roller.parent().show();
setX(number * $(rollerChild[number]).outerWidth());
);



$('#roller-n').click(function()
if(childNumber - howBig() === number) return;
number++;
setX(getTranslteX() +
$(rollerChild[number]).outerWidth());
);

$('#roller-p').click(function()
if(number === 0) return;
number--;
setX(Math.abs(getTranslteX() -
$(rollerChild[number]).outerWidth()));
);


$(window).on('resize', function()
if(childNumber - howBig() < number) number =
childNumber - howBig();
setX(number * $(rollerChild[number]).outerWidth());
);






share|improve this question













I've been doing this image slider section, I've been working on this code for quite a time, the code is perfectly working but I want to improve it.



I tried for hours and couldn't find a way. Maybe because I'm too in my code that I can't see other better options.



Can you guys suggest me a better way to improve my code?



let $roller = $('#management_roller .manage-roller');
let rollerChild = $roller.children();
let childNumber = rollerChild.length;
let number = 0;

const getTranslteX = () => matrix[4]

const howBig = () =>
const windowW = window.innerWidth;
if(windowW <= 576)
return 1;
else if(windowW <= 768)
return 2;
else if(windowW <= 1200)
return 3;
else
return 4;




const setX = (n) =>
$roller.css('transform' : 'translateX(-' + n +'px)');




$('#roller_links a').click(function(e)
e.preventDefault();

$('#roller_links a').removeClass('active');
const id = $(this).attr('id');
const rollerP = $roller.parent();

$(this).addClass('active');
rollerP.hide();
$roller = $('#' + id + '_roller .manage-roller');
rollerChild = $roller.children();
number = 0;
$roller.parent().show();
setX(number * $(rollerChild[number]).outerWidth());
);



$('#roller-n').click(function()
if(childNumber - howBig() === number) return;
number++;
setX(getTranslteX() +
$(rollerChild[number]).outerWidth());
);

$('#roller-p').click(function()
if(number === 0) return;
number--;
setX(Math.abs(getTranslteX() -
$(rollerChild[number]).outerWidth()));
);


$(window).on('resize', function()
if(childNumber - howBig() < number) number =
childNumber - howBig();
setX(number * $(rollerChild[number]).outerWidth());
);








share|improve this question












share|improve this question




share|improve this question








edited Mar 21 at 14:29









Mast

7,32863484




7,32863484









asked Mar 21 at 14:24









Assaf

111




111











  • Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
    – Sam Onela
    Mar 22 at 5:50
















  • Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
    – Sam Onela
    Mar 22 at 5:50















Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
– Sam Onela
Mar 22 at 5:50




Are you able to add the basic HTML elements that accompany this JS? If so, please edit the post and add it.
– Sam Onela
Mar 22 at 5:50















active

oldest

votes











Your Answer




StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: false,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);








 

draft saved


draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f190126%2fimage-slider-code%23new-answer', 'question_page');

);

Post as a guest



































active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes










 

draft saved


draft discarded


























 


draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f190126%2fimage-slider-code%23new-answer', 'question_page');

);

Post as a guest













































































Popular posts from this blog

Greedy Best First Search implementation in Rust

Function to Return a JSON Like Objects Using VBA Collections and Arrays

C++11 CLH Lock Implementation