trjhtr

What do you think about my saving method? I'm saving an issue with GPS location and e.t.c, and then uploads it to a server.

public Task<bool> SaveIssue(UIIssueVM uiIssue)

 return Task.Run(async () =>
 
 try
 
 uiIssue.bNeedSync = true;
 var wifi = Plugin.Connectivity.Abstractions.ConnectionType.WiFi;
 var connectionTypes = CrossConnectivity.Current.ConnectionTypes;
 if (connectionTypes.Contains(wifi))
 
 //Save Issue to cache..
 UserDialogs.Instance.ShowLoading("Saving...", maskType: MaskType.Clear);

 if (uiIssue.IsNew)
 App.Client.AddIssue(uiIssue);
 else
 App.Client.UpdateIssue(uiIssue);


 UserDialogs.Instance.HideLoading();

 uiIssue.bNeedSync = false;
 
 else
 
 if (CrossConnectivity.Current.IsConnected)
 await App.Client.AddIssueLocal(uiIssue);
 return false;
 
 return true;
 
 catch (Exception ex)
 
 LastErrorText = ex.Message;
 return false;
 
 );



public ViewModels.Issue.NewIssueVM CreateNewIssueVM()

 ViewModels.Issue.NewIssueVM issue = new ViewModels.Issue.NewIssueVM();
 issue.LocationId = LocationId;
 issue.Title = Title;
 issue.Description = Description;
 issue.Longitude = Longitude;
 issue.Latitude = Latitude;
 issue.Status = Status;
 issue.Severity = Severity;
 return issue;


public void AddIssue(UIIssueVM uiIssue)

 if (uiIssue.LocationId == 0)
 uiIssue.LocationId = state.LocationID;

 NewIssueVM issue = uiIssue.CreateNewIssueVM();
 int IssueID = apiClient.CreateIssue(issue);
 if (IssueID > 0)
 uiIssue.Id = IssueID;

 if (uiIssue.IsNew == true)
 uiIssue.IsNew = false;


public int CreateIssue( NewIssueVM vm )

 return CreateResource( "api/Issue/v1/CreateIssue", vm );


private int CreateResource<T>( string action, T vm )

 var response = PerformRequest( HttpVerb.Post, action, vm );

 var content = ParseContent<ReturnID>( response );
 return content.Id;


private void UpdateResource<T>( string action, T vm )

 PerformRequest( HttpVerb.Put, action, vm );


private T GetResource<T>( string action )

 var response = PerformRequest( HttpVerb.Get, action );

 var resource = ParseContent<T>( response );
 return resource;



public class NewIssueVM

 public int LocationId get; set; 
 public string Title get; set; 
 public string Description get; set; 
 public double Longitude get; set; 
 public double Latitude get; set; 
 public IssueStatus Status get; set; 
 public IssueSeverity Severity get; set;