Legacy code: break in if block without a loop [closed]

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
-1
down vote

favorite












I am a beginner in shell scripting and I am working on a legacy project where I need to maintain/enhance the shell scripts.
I came across the following code block in a shell script.



if [ some_condition ]; then
 do_something
 break
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


As you can see, there are no loops involved here and original author uses break in the if block!
As I am doing enhancement, I thought of changing it to 



if [ some_condition ]; then
 do_something
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


Questions:
I believe, break in the original code is a bad coding. Am I correct? If not what is the use of it there in the block?




shell ksh




share|improve this question











closed as off-topic by Stephen Rauch, Sam Onela, Imus, Dannnno, Mast Apr 6 at 14:29


This question appears to be off-topic. The users who voted to close gave these specific reasons:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – Sam Onela, Dannnno, Mast

  • "Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and that the poster know why the code is written the way it is." – Stephen Rauch, Imus

If this question can be reworded to fit the rules in the help center, please edit the question.








  • 3




    I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
    – Dannnno
    Apr 6 at 13:30
















up vote
-1
down vote

favorite












I am a beginner in shell scripting and I am working on a legacy project where I need to maintain/enhance the shell scripts.
I came across the following code block in a shell script.



if [ some_condition ]; then
 do_something
 break
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


As you can see, there are no loops involved here and original author uses break in the if block!
As I am doing enhancement, I thought of changing it to 



if [ some_condition ]; then
 do_something
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


Questions:
I believe, break in the original code is a bad coding. Am I correct? If not what is the use of it there in the block?




shell ksh




share|improve this question











closed as off-topic by Stephen Rauch, Sam Onela, Imus, Dannnno, Mast Apr 6 at 14:29


This question appears to be off-topic. The users who voted to close gave these specific reasons:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – Sam Onela, Dannnno, Mast

  • "Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and that the poster know why the code is written the way it is." – Stephen Rauch, Imus

If this question can be reworded to fit the rules in the help center, please edit the question.








  • 3




    I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
    – Dannnno
    Apr 6 at 13:30












up vote
-1
down vote

favorite









up vote
-1
down vote

favorite











I am a beginner in shell scripting and I am working on a legacy project where I need to maintain/enhance the shell scripts.
I came across the following code block in a shell script.



if [ some_condition ]; then
 do_something
 break
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


As you can see, there are no loops involved here and original author uses break in the if block!
As I am doing enhancement, I thought of changing it to 



if [ some_condition ]; then
 do_something
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


Questions:
I believe, break in the original code is a bad coding. Am I correct? If not what is the use of it there in the block?




shell ksh




share|improve this question











I am a beginner in shell scripting and I am working on a legacy project where I need to maintain/enhance the shell scripts.
I came across the following code block in a shell script.



if [ some_condition ]; then
 do_something
 break
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


As you can see, there are no loops involved here and original author uses break in the if block!
As I am doing enhancement, I thought of changing it to 



if [ some_condition ]; then
 do_something
else 
 if [ some_condition ]; then
 do_some_other_thing
 exit 1
 fi
fi


Questions:
I believe, break in the original code is a bad coding. Am I correct? If not what is the use of it there in the block?





shell ksh





share|improve this question










share|improve this question




share|improve this question









asked Apr 6 at 10:03









NJMR

1384




1384




closed as off-topic by Stephen Rauch, Sam Onela, Imus, Dannnno, Mast Apr 6 at 14:29


This question appears to be off-topic. The users who voted to close gave these specific reasons:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – Sam Onela, Dannnno, Mast

  • "Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and that the poster know why the code is written the way it is." – Stephen Rauch, Imus

If this question can be reworded to fit the rules in the help center, please edit the question.




closed as off-topic by Stephen Rauch, Sam Onela, Imus, Dannnno, Mast Apr 6 at 14:29


This question appears to be off-topic. The users who voted to close gave these specific reasons:


  • "Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site." – Sam Onela, Dannnno, Mast

  • "Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and that the poster know why the code is written the way it is." – Stephen Rauch, Imus

If this question can be reworded to fit the rules in the help center, please edit the question.







  • 3




    I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
    – Dannnno
    Apr 6 at 13:30












  • 3




    I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
    – Dannnno
    Apr 6 at 13:30







3




3




I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
– Dannnno
Apr 6 at 13:30




I'm afraid this question does not match what this site is about. Code Review is about improving existing, working code. The example code that you have posted is not reviewable in this form because it leaves us guessing at your intentions. Unlike Stack Overflow, Code Review needs to look at concrete code in a real context. Please see Why is hypothetical example code off-topic for CR?
– Dannnno
Apr 6 at 13:30










1 Answer
1






active

oldest

votes

















up vote
1
down vote













The break statement is used to exit the current loop before its normal ending so, in this case, it is useless.






share|improve this answer




























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes








    up vote
    1
    down vote













    The break statement is used to exit the current loop before its normal ending so, in this case, it is useless.






    share|improve this answer

























      up vote
      1
      down vote













      The break statement is used to exit the current loop before its normal ending so, in this case, it is useless.






      share|improve this answer























        up vote
        1
        down vote










        up vote
        1
        down vote









        The break statement is used to exit the current loop before its normal ending so, in this case, it is useless.






        share|improve this answer













        The break statement is used to exit the current loop before its normal ending so, in this case, it is useless.







        share|improve this answer













        share|improve this answer



        share|improve this answer











        answered Apr 6 at 12:36









        Andrea Girardi

        1193




        1193












            -

            Popular posts from this blog

            Chat program with C++ and SFML

            Image
            Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 2 down vote favorite This is my client code: (My server is very similar at the moment but I will upload it below this one just in case somebody wants to run it) #include <SFML/Graphics.hpp> #include <SFML/Network.hpp> #include <thread> int main() sf::RenderWindow main_win(sf::VideoMode(800, 800), "Chatcy!"); main_win.setPosition(sf::Vector2i(sf::VideoMode::getDesktopMode().width/2 -400, sf::VideoMode::getDesktopMode().height/2 -400)); main_win.setVerticalSyncEnabled(true); //chatcy logo sf::Texture chatcy; chatcy.loadFromFile("image_chatcy.png"); sf::Sprite logo; logo.setTexture(chatcy); //200x800 //font sf::Font font; font.loadFromFile("FreeSerif.ttf"); //name sf::String name("Client"); name += ": "; //text input area and background sf::RectangleShape in_backg
            Read more

            Function to Return a JSON Like Objects Using VBA Collections and Arrays

            Image
            Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 1 down vote favorite My goal is to create a compact function that can create a JSON Like object from JSON string. I want a function with a small footprint that I or anyone who wants to use it, can simply paste into a module and use. At 61 lines of code, I am happy with its size and portability. Here is an image of JSON Object created from string data using a ScriptControl . Although the Locals Window displays the properties and values correctly, the object itself is extremely difficult to work with. This image shows an object created using getJSONCollection . Because it is made of VBA Collections and Arrays, it is very easy to work with. Option Explicit Private Function getJSONCollection(ByVal Value As Variant, Optional ScriptEngine As Object) As Variant Const DELIMITER As String = "||" Dim col As Collection, JSON As Object, KeyNam
            Read more

            Will my employers contract hold up in court?

            Image
            Clash Royale CLAN TAG #URR8PPP up vote 8 down vote favorite 2 When I started a new job back in July of 2017, I signed a contract that had the following bindings or restrictions if I was ever to leave the company: Cannot work for a competitor within 25 miles of current companies location for the next two years Cannot offer my services to any organization within 25 miles of current companies location for the next two years Now, when mentioned “my services” this can be related to my profession of website design. This contract seems incredibly binding, 2 years in length, and I’m looking to see if it would actually hold up in an Arizona court. contract employment non-compete arizona share | improve this question edited Aug 7 at 15:35 feetwet ♦ 13.8k 9 37 85 asked Aug 6 at 19:05 Alex S. 46 2 What does your company do and what services do they provide? What is your role (i.e. internal work or work for customers).
            Read more