trjhtr

I'm not sure how to properly implement a simple CursorLoader that loads data directly from a SQLite database and displays it in a ListView in a Fragment, as most examples I've found require creating a ContentProvider.

The code I have at the moment seems to be working as expected, but I want to make sure there are no hidden surprises that are waiting to crash my application.

public class TodoFragment extends Fragment implements LoaderManager.LoaderCallbacks<Cursor> 

 private TodoAdapter mAdapter = null;

 public TodoFragment() 
 // Required empty public constructor
 


 @Override
 public void onActivityCreated(@Nullable Bundle savedInstanceState) 
 super.onActivityCreated(savedInstanceState);
 getLoaderManager().initLoader(0, null, this);
 

 @Override
 public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) 
 View view = inflater.inflate(R.layout.todo_fragment, container, false);

 mAdapter = new TodoAdapter(getActivity(), null, 0);

 ListView listView = ((ListView) view.findViewById(R.id.todo_listview));
 listView.setAdapter(mAdapter);

 return view;
 

 /**
 * My custom CursorLoader for Todo-items
 */
 private static class TodoCursorLoader extends CursorLoader 
 public TodoCursorLoader(Context context) 
 super(context);
 

 @Override
 public Cursor loadInBackground() 
 // This method returns a Cursor to all the items in the DB table
 return MyApplication.getDbHelper().getAllTodoItems();
 
 



 /**
 * LoaderManager.LoaderCallbacks implementation
 */
 @Override
 public Loader<Cursor> onCreateLoader(int id, Bundle args) 
 return new TodoCursorLoader(getActivity());
 

 @Override
 public void onLoadFinished(Loader<Cursor> loader, Cursor cursor) 
 mAdapter.swapCursor(cursor);
 

 @Override
 public void onLoaderReset(Loader<Cursor> loader) 
 mAdapter.swapCursor(null);
 
 /** -- **/

The fragment can be hidden and shown, and INSERT/UPDATE/DELETE can only be performed on the database while the TodoFragment is not visible (from another Fragment).

Does this look correct?