trjhtr

I have a function that takes a time of minutes and seconds, and converts it to a string in the following way: '0:30' would become '30 Seconds', '1:30' would become '1 minute 30 seconds', '2:01' would become '2 minutes 1 second', etc. My function works fine, but I'm wondering if there are areas for improvement.

function formatTime(formattedTime) 
 let minStr, secStr;
 let minNum = formattedTime.split(':')[0];
 let secNum = formattedTime.split(':')[1];
 if (minNum === '1') 
 minStr = 'minute';
 else 
 minStr = 'minutes';
 
 if (secNum === '01') 
 secStr = 'second';
 secNum = '1';
 else 
 secStr = 'seconds';
 
 if (minNum === '0') 
 return `$secNum $secStr`;
 else if (secNum === '00') 
 return `$minNum $minStr`;
 else 
 return `$minNum $minStr $secNum $secStr`;
 

I made a few changes to the function that I think improve readability. By using parseInt() on the seconds, I eliminated the need to later set the secNum from 01 to 1. Since we no longer need to change that, the minStr and secStr can be set with a ternary operator. I also used destructuring to clean up the splitting of the time.

To make it less error prone, you'd also want to make sure to do some sanity checks on the input, as mentioned in the comments.

All told, it ended up looking like this:

// Tests
console.log(formatTime('1:00'))
console.log(formatTime('1:01'))
console.log(formatTime('1:30'))
console.log(formatTime('0:30'))
console.log(formatTime('bad data'))

function formatTime(formattedTime) ;
 
 // Make sure we're getting the data in correct
 if(!match) return false;

 // Get the correct minutes and seconds strings
 let minStr = (minNum === '1') ? 'minute' : 'minutes'
 let secStr = (parseInt(secNum) === 1) ? 'second' : 'seconds'

 // Return the formatted time
 if (parseInt(minNum) === 0) 
 return `$secNum $secStr`;
 else if (parseInt(secNum) === 0) 
 return `$minNum $minStr`;
 else 
 return `$minNum $minStr $parseInt(secNum) $secStr`;
 

This is making use of some ES6 additions, so if you want good browser support you'll need to make sure to run this through Babel.