Method to store X509 certificate from Database

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP





.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0;







up vote
0
down vote

favorite












I've a method that gets certificate as BLOB and password as char from Oracle Database, store this certificate x509, trust it, get the secure connection and verify Hostname.



This is the code:



public void openCert() throws Exception CertificateException e) 
 this.Message = "Err.openCert: ";
 throw new Exception(this.Message + e);
 catch (SQLException e) 
 this.Message = "Err.openCert.getCert["+line+"]: ";
 throw new Exception(this.Message + e);
 catch (Exception e) 
 this.Message = "Err.openCert.UncaughtException: ";
 throw new Exception(this.Message + e);
 finally 
 if(conn != null) 
 conn.close();



Do you have any idea to how improve the code and refactor it?




java sql oracle ssl




share|improve this question













migrated from stackoverflow.com May 15 at 20:58


This question came from our site for professional and enthusiast programmers.














  • There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
    – user207421
    May 14 at 16:34










  • What is a Conexion?
    – 200_success
    May 15 at 22:38










  • Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
    – Rancio
    May 16 at 5:45










  • I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
    – RobAu
    May 17 at 8:30
















up vote
0
down vote

favorite












I've a method that gets certificate as BLOB and password as char from Oracle Database, store this certificate x509, trust it, get the secure connection and verify Hostname.



This is the code:



public void openCert() throws Exception CertificateException e) 
 this.Message = "Err.openCert: ";
 throw new Exception(this.Message + e);
 catch (SQLException e) 
 this.Message = "Err.openCert.getCert["+line+"]: ";
 throw new Exception(this.Message + e);
 catch (Exception e) 
 this.Message = "Err.openCert.UncaughtException: ";
 throw new Exception(this.Message + e);
 finally 
 if(conn != null) 
 conn.close();



Do you have any idea to how improve the code and refactor it?




java sql oracle ssl




share|improve this question













migrated from stackoverflow.com May 15 at 20:58


This question came from our site for professional and enthusiast programmers.














  • There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
    – user207421
    May 14 at 16:34










  • What is a Conexion?
    – 200_success
    May 15 at 22:38










  • Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
    – Rancio
    May 16 at 5:45










  • I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
    – RobAu
    May 17 at 8:30












up vote
0
down vote

favorite









up vote
0
down vote

favorite











I've a method that gets certificate as BLOB and password as char from Oracle Database, store this certificate x509, trust it, get the secure connection and verify Hostname.



This is the code:



public void openCert() throws Exception CertificateException e) 
 this.Message = "Err.openCert: ";
 throw new Exception(this.Message + e);
 catch (SQLException e) 
 this.Message = "Err.openCert.getCert["+line+"]: ";
 throw new Exception(this.Message + e);
 catch (Exception e) 
 this.Message = "Err.openCert.UncaughtException: ";
 throw new Exception(this.Message + e);
 finally 
 if(conn != null) 
 conn.close();



Do you have any idea to how improve the code and refactor it?




java sql oracle ssl




share|improve this question













I've a method that gets certificate as BLOB and password as char from Oracle Database, store this certificate x509, trust it, get the secure connection and verify Hostname.



This is the code:



public void openCert() throws Exception CertificateException e) 
 this.Message = "Err.openCert: ";
 throw new Exception(this.Message + e);
 catch (SQLException e) 
 this.Message = "Err.openCert.getCert["+line+"]: ";
 throw new Exception(this.Message + e);
 catch (Exception e) 
 this.Message = "Err.openCert.UncaughtException: ";
 throw new Exception(this.Message + e);
 finally 
 if(conn != null) 
 conn.close();



Do you have any idea to how improve the code and refactor it?





java sql oracle ssl





share|improve this question












share|improve this question




share|improve this question








edited May 15 at 22:38









200_success

123k14143399




123k14143399









asked May 14 at 16:28









Rancio

1




1




migrated from stackoverflow.com May 15 at 20:58


This question came from our site for professional and enthusiast programmers.






migrated from stackoverflow.com May 15 at 20:58


This question came from our site for professional and enthusiast programmers.













  • There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
    – user207421
    May 14 at 16:34










  • What is a Conexion?
    – 200_success
    May 15 at 22:38










  • Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
    – Rancio
    May 16 at 5:45










  • I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
    – RobAu
    May 17 at 8:30
















  • There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
    – user207421
    May 14 at 16:34










  • What is a Conexion?
    – 200_success
    May 15 at 22:38










  • Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
    – Rancio
    May 16 at 5:45










  • I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
    – RobAu
    May 17 at 8:30















There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
– user207421
May 14 at 16:34




There is no key pair here, ergo no keystore either, only a truststore. You aren't checking the value of resultSet.next(). Off topic.
– user207421
May 14 at 16:34












What is a Conexion?
– 200_success
May 15 at 22:38




What is a Conexion?
– 200_success
May 15 at 22:38












Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
– Rancio
May 16 at 5:45




Conexión is a class that extends Connection and do more things, works like Connetion class and take DB connection from a .properties.
– Rancio
May 16 at 5:45












I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
– RobAu
May 17 at 8:30




I don't get what the use of the HostnameVerifier empty if statement is..Seems broken code?
– RobAu
May 17 at 8:30















active

oldest

votes











Your Answer




StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: false,
noModals: false,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);








 

draft saved


draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f194494%2fmethod-to-store-x509-certificate-from-database%23new-answer', 'question_page');

);

Post as a guest






















active

oldest

votes













active

oldest

votes









active

oldest

votes






active

oldest

votes










 

draft saved


draft discarded


























 


draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f194494%2fmethod-to-store-x509-certificate-from-database%23new-answer', 'question_page');

);

Post as a guest
































































-

Popular posts from this blog

Chat program with C++ and SFML

Image
Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 2 down vote favorite This is my client code: (My server is very similar at the moment but I will upload it below this one just in case somebody wants to run it) #include <SFML/Graphics.hpp> #include <SFML/Network.hpp> #include <thread> int main() sf::RenderWindow main_win(sf::VideoMode(800, 800), "Chatcy!"); main_win.setPosition(sf::Vector2i(sf::VideoMode::getDesktopMode().width/2 -400, sf::VideoMode::getDesktopMode().height/2 -400)); main_win.setVerticalSyncEnabled(true); //chatcy logo sf::Texture chatcy; chatcy.loadFromFile("image_chatcy.png"); sf::Sprite logo; logo.setTexture(chatcy); //200x800 //font sf::Font font; font.loadFromFile("FreeSerif.ttf"); //name sf::String name("Client"); name += ": "; //text input area and background sf::RectangleShape in_backg
Read more

Function to Return a JSON Like Objects Using VBA Collections and Arrays

Image
Clash Royale CLAN TAG #URR8PPP .everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty margin-bottom:0; up vote 1 down vote favorite My goal is to create a compact function that can create a JSON Like object from JSON string. I want a function with a small footprint that I or anyone who wants to use it, can simply paste into a module and use. At 61 lines of code, I am happy with its size and portability. Here is an image of JSON Object created from string data using a ScriptControl . Although the Locals Window displays the properties and values correctly, the object itself is extremely difficult to work with. This image shows an object created using getJSONCollection . Because it is made of VBA Collections and Arrays, it is very easy to work with. Option Explicit Private Function getJSONCollection(ByVal Value As Variant, Optional ScriptEngine As Object) As Variant Const DELIMITER As String = "||" Dim col As Collection, JSON As Object, KeyNam
Read more

Will my employers contract hold up in court?

Image
Clash Royale CLAN TAG #URR8PPP up vote 8 down vote favorite 2 When I started a new job back in July of 2017, I signed a contract that had the following bindings or restrictions if I was ever to leave the company: Cannot work for a competitor within 25 miles of current companies location for the next two years Cannot offer my services to any organization within 25 miles of current companies location for the next two years Now, when mentioned “my services” this can be related to my profession of website design. This contract seems incredibly binding, 2 years in length, and I’m looking to see if it would actually hold up in an Arizona court. contract employment non-compete arizona share | improve this question edited Aug 7 at 15:35 feetwet ♦ 13.8k 9 37 85 asked Aug 6 at 19:05 Alex S. 46 2 What does your company do and what services do they provide? What is your role (i.e. internal work or work for customers).
Read more