trjhtr

I'm working on WEB API project and I just start coding the first CRUD operations. So far, I'm using a JSON file as a "database" to serialize/deserialize a list of Books. So for that, I have a C# class BookCollection that will:

• Add, delete, update, and read a Book.


• Maintain a collection of Books with unique Id, unique Title and unique Rank also:
  
  
  • Unique Id even after serialize/deserialize. For that We have a property NextId and a Dictionary<int, Book>
    
  
  
  • Unique Title that could be changed later on (that's Why We can't rely on it as a "real" ID). For that We have the HashSet<string>
    
  
  
  • 
    Rank is kind of order of preference for each Book. For example, We can have book1, book2, and book3 with an order of preference (Rank) of 3, 1, and 2. Which means, Rank should be unique and between [1..NumberOfBooks]. Also When changing a Rank for one book, We need to update the Rank for all other books accordingly. In the title, I said index, because to me Rank is the same as an array index.
  
  

Here is my code:

public class Book

 public int Id set; get; 
 public string Title set; get; 
 public int Rank set; get; 


public class BookCollection

 public int NextId set; get; 
 private readonly IDictionary<int, Book> m_Dictionary;
 private readonly ISet<string> m_HashSet;

 public BookCollection()
 
 m_Dictionary = new Dictionary<int, Book>();
 m_HashSet = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
 

 public bool Add(Book item)
 
 item.Id = NextId++;
 if (m_Dictionary.ContainsKey(item.Id)) return false;
 if (m_HashSet.Contains(item.Title)) return false;
 m_Dictionary.Add(item.Id, item);
 m_HashSet.Add(item.Title);
 updateRanks(item.Rank, true);
 return true;
 

 public bool Remove(Book item)
 
 bool found = m_Dictionary.ContainsKey(item.Id);
 if (!found) return false;
 m_Dictionary.Remove(item.Id);
 m_HashSet.Remove(item.Title);
 updateRanks(item.Rank, false);
 return true;
 

 public bool Update(Book item)
 
 if (m_Dictionary.ContainsKey(item.Id)) return false;
 if (m_HashSet.Contains(item.Title)) return false;
 m_HashSet.Remove(m_Dictionary[item.Id].Title);
 m_Dictionary[item.Id] = item;
 m_HashSet.Add(item.Title);
 updateRanks(item.Rank, true);
 return true;
 

 public IEnumerable<Book> GetAllBooks()
 
 return m_Dictionary.Values;
 

 public bool Contains(Book item)
 
 return m_Dictionary.ContainsKey(item.Id);
 

 private void updateRanks(int rank, bool increment)
 
 foreach (var book in m_Dictionary.Values)
 
 if (rank <= book.Rank)
 
 book.Rank = increment ? book.Rank + 1 : book.Rank - 1;
 
 
 

I want to build a collection that could handle all CRUD operations in the most performant way.

Any suggestion How to make this collection better?